Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOCS.md #3307

Closed
wants to merge 1 commit into from
Closed

Conversation

Mariusthvdb
Copy link

change to the new (version 11.0.0) homeassistant folder

change to the new (version 11.0.0) homeassistant folder
@frenck frenck marked this pull request as draft November 11, 2023 11:46
@frenck
Copy link
Member

frenck commented Nov 11, 2023

Converting to draft, as we are currently re-considering this change.

@Mariusthvdb
Copy link
Author

ok, sorry, I wasnt aware..
had posted this for some clarification https://community.home-assistant.io/t/samba-add-on-changed-config-to-homeassistant/639230 but if you reconsider that wont be the case..

@frenck
Copy link
Member

frenck commented Nov 11, 2023

had posted this for some clarification community.home-assistant.io/t/samba-add-on-changed-config-to-homeassistant/639230 but if you reconsider that wont be the case..

I do not understand that post. This is not designed as a user-facing change. /config is just as normal. The share name simply changed to make a clear difference between the addon configuration (newly added, and being rolled out right now) and Home Assistant configuration.

From all ends, /config will remain to be used.

@boheme61
Copy link

boheme61 commented Nov 11, 2023

Maybe you could just add a symlink in / or /supervisor-folder , and add to smb.gtp1 -file

[share]
follow symlinks = yes

or maybe not, forget it !, i seems to just have realized a symlink in here is to a file(what it seem from samba.org) :)

However the symlink works in cli(login) and over terminal, it's just windows>samba who might need follow-symlink

@langestefan
Copy link

I do not understand that post. This is not designed as a user-facing change. /config is just as normal. The share name simply changed to make a clear difference between the addon configuration (newly added, and being rolled out right now) and Home Assistant configuration.

This is a user facing change. This broke the network share of everyone using the samba addon, which must now mount homeassistant instead of config.

@frenck
Copy link
Member

frenck commented Nov 12, 2023

Replaced by #3311

@frenck frenck closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants