Created a media player control widget #1005
Conversation
KBerstene
changed the title
| android:minHeight="40dp" | ||
| android:updatePeriodMillis="86400000" | ||
| android:widgetCategory="home_screen" /> | ||
| <!--android:previewImage="@drawable/example_appwidget_preview"--> |
There was a problem hiding this comment.
I think going forward we are going to want every widget to include a preview image. If you need help with it let me know and I can add it. I personally just took a screenshot of the widget, cropped and set leftover background transparent.
There was a problem hiding this comment.
Ah, totally forgot to include that. I saw your other preview images, I'll try one like those.
There was a problem hiding this comment.
I added a preview image in commit e3a66e5, but it's in light mode instead of dark mode. Do you want it to be dark mode to match the rest or light mode to have an example of what the light mode widgets look like?
| } | ||
|
|
||
| private suspend fun retrieveMediaPlayerImageUrl(entityId: String): String? { | ||
| val entity = integrationUseCase.getEntities().find { e -> e.entityId.equals(entityId) } |
There was a problem hiding this comment.
This can be an expensive call, I know we use it elsewhere but we should consider either in this PR or in the near future add a way to get a single entity rather than all of the entities.
There was a problem hiding this comment.
I 100% agree. I saw that the Static widget was using it and was incredibly surprised it hadn't been more targeted. I'll see if I can add the code to call just the single entity as part of the next set of changes in this PR.
There was a problem hiding this comment.
Implemented this change in d923e8c. Obviously, I had to add an additional GET call in the integration repository. There are a few things in there that work but I'm not sure if they are the best method possible (specifically SingleEntityResponse) that I would appreciate you looking at extra-closely.
...o/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidget.kt
Outdated
Show resolved
Hide resolved
...o/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidget.kt
Outdated
Show resolved
Hide resolved
...o/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidget.kt
Outdated
Show resolved
Hide resolved
...o/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidget.kt
Outdated
Show resolved
Hide resolved
...o/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidget.kt
Outdated
Show resolved
Hide resolved
| <ImageView | ||
| android:id="@+id/widgetMediaImage" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:visibility="invisible" | ||
| android:contentDescription="@string/widget_media_image_description" | ||
| android:scaleType="centerCrop" /> | ||
| <ImageView | ||
| android:id="@+id/widgetMediaPlaceholder" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:layout_marginStart="4dp" | ||
| android:layout_marginTop="4dp" | ||
| android:layout_marginBottom="4dp" | ||
| android:src="@drawable/app_icon" | ||
| android:contentDescription="@string/widget_media_image_description" | ||
| android:scaleType="fitCenter" /> |
There was a problem hiding this comment.
Can we just use the same ImageView and replace the image when we have/don't have an image?
There was a problem hiding this comment.
The reason I have it set like this is because of the margins. If the image is supposed to take up the entire left-hand section, it can't have any margins on it, but the placeholder looks silly if it is touching the edge. I can give you some screenshots of what it looks like if it's just straight replacement if you'd like.
|
I will get on these changes at my next opportunity. Work's been crazy lately so I might not have the energy to take care of it until next weekend, but I'll try to get something done this week. Thanks as always for digging through my crap and finding these fixes! |
… all entities and parsing results
| suspend fun getState( | ||
| @Header("Authorization") auth: String, | ||
| @Path("entity") entityId: String | ||
| ): SingleEntityResponse<Any> |
There was a problem hiding this comment.
We don't need to create another object, can just reuse the one we use when requesting all states. Then if we get a message back we can just throw an exception rather than return null.
| ): SingleEntityResponse<Any> | |
| ): EntityResponse<Any> |
| @@ -380,6 +380,31 @@ class IntegrationRepositoryImpl @Inject constructor( | |||
| }.toTypedArray() | |||
| } | |||
|
|
|||
| override suspend fun getEntity(entityId: String): Entity<Any>? { | |||
There was a problem hiding this comment.
Probably want to throw an exception if we don't have the entity.
| override suspend fun getEntity(entityId: String): Entity<Any>? { | |
| override suspend fun getEntity(entityId: String): Entity<Any> { |
I'm working on creating a 4x1 widget for media player entities. It has a spot for a picture of the currently playing media, a label, a play/pause button, and optional seek/skip buttons.
I've added the Picasso library (https://github.com/square/picasso) for fetching an image URL and loading it into the widget ImageView. Just like the state widget, this is only updated when the image is clicked on. If webhooks ever get implemented, it would be a good idea to add this to the list of things to get updated via webhooks (along with the play/pause button being replaced by play or pause buttons depending on the state of the media player).
Below is an image of the the variations on the buttons:
Image with media loaded (set to center crop, which seems to be the best option, or at least better than center fit):
Image of the configure screen: