Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle Build Scans #1050

Merged
merged 2 commits into from Oct 16, 2020
Merged

Conversation

runningcode
Copy link
Contributor

@runningcode
Copy link
Contributor Author

This also publishes scans for CI runs making it easy to see the test results

@JBassett
Copy link
Collaborator

Rather than forcing everyone to upload every build we should probably limit to only CI builds. You can use the CI variable defined here in the github actions: https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables

buildScan {
termsOfServiceUrl = "https://gradle.com/terms-of-service"
termsOfServiceAgree = "yes"
publishAlwaysIf(isCI)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JBassett good idea. I implemented the change you requested.

@JBassett JBassett merged commit 28152b6 into home-assistant:master Oct 16, 2020
@runningcode runningcode deleted the no/add-build-scans branch October 16, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants