Revert material bump as it introduced a dark theme issue with the widgets #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
approved these changes
Oct 31, 2020
|
Since this update the bulb icon on the widget turned black. |
|
@SeLLeRoNe please do not comment on merged PRs, always create an issue if you find one. For this the issue actually existed before this PR, I thought it fixed the issue but it didn't. We may have a solution to check and see if it actually resolves it. |
This was referenced Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon for the service button widget was coming in as light theme when the device theme was set to dark, reverting the library bump fixes the issue. Seems the new library version introduced an issue where the night theme color is not being read properly.
Ref: https://discord.com/channels/330944238910963714/562408603345092636/772138149395824661