Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Filtering #1138

Merged
merged 4 commits into from Nov 3, 2020
Merged

Sentry Filtering #1138

merged 4 commits into from Nov 3, 2020

Conversation

JBassett
Copy link
Collaborator

@JBassett JBassett commented Nov 2, 2020

Summary

This should remove exceptions about being unable to connect home assistant instances. This will greatly reduce the number of events in Sentry and help with diagnosing issues.

Screenshots

N/A

Link to pull request in Documentation repository

N/A

Any other notes

Sentry: ANDROID-1EB, ANDROID-1E6, ANDROID-1EK, ANDROID-1F3, etc

@JBassett JBassett changed the title Feature/sentry filtering Sentry Filtering Nov 2, 2020

SentryAndroid.init(context) { options ->
options.isEnableSessionTracking = true
options.isEnableNdk = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, disregard my deleted comment lol

is SSLHandshakeException,
is SSLProtocolException,
is UnknownHostException -> null
else -> event
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include HTTPException?

Because of how the dependencies are setup we can't right now, but we can explore in the future.

Sentry also has their ANR issues that I am not sure if we need them?

ANR (App not responding) are events we should investigate further. Most likely means we are doing something on the main thread we shouldn't be.

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we don't need to bump the library do we? I noticed they changed the dependency name lately 😬

@JBassett
Copy link
Collaborator Author

JBassett commented Nov 2, 2020

Looks good to me, we don't need to bump the library do we? I noticed they changed the dependency name lately

Good catch, just checked https://docs.sentry.io/platforms/android/migration/ and validated our upgrade with no issues.

@JBassett JBassett merged commit a4f8ac5 into master Nov 3, 2020
@JBassett JBassett deleted the feature/sentryFiltering branch May 7, 2021 01:36
anyuta1166 added a commit to anyuta1166/android that referenced this pull request Mar 10, 2022
…Add ability to opt out of crash reporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants