New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry Filtering #1138
Sentry Filtering #1138
Conversation
|
||
SentryAndroid.init(context) { options -> | ||
options.isEnableSessionTracking = true | ||
options.isEnableNdk = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now, disregard my deleted comment lol
is SSLHandshakeException, | ||
is SSLProtocolException, | ||
is UnknownHostException -> null | ||
else -> event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include HTTPException
? Like: https://sentry.io/organizations/home-assistant-io/issues/1823402301/?project=5372876&query=is%3Aunresolved
Sentry also has their ANR issues that I am not sure if we need them? https://sentry.io/organizations/home-assistant-io/issues/1863659368/?project=5372876&query=is%3Aunresolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include
HTTPException
?
Because of how the dependencies are setup we can't right now, but we can explore in the future.
Sentry also has their ANR issues that I am not sure if we need them?
ANR (App not responding) are events we should investigate further. Most likely means we are doing something on the main thread we shouldn't be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we don't need to bump the library do we? I noticed they changed the dependency name lately 😬
Good catch, just checked https://docs.sentry.io/platforms/android/migration/ and validated our upgrade with no issues. |
…Add ability to opt out of crash reporting.
Summary
This should remove exceptions about being unable to connect home assistant instances. This will greatly reduce the number of events in Sentry and help with diagnosing issues.
Screenshots
N/A
Link to pull request in Documentation repository
N/A
Any other notes
Sentry: ANDROID-1EB, ANDROID-1E6, ANDROID-1EK, ANDROID-1F3, etc