Don't show toast error for screen on intent as it can be excessive #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The other day my internet went out and I started to see a lot of toast errors. The error was expected since I could not connect to my HA instance. The problem is the screen on intent can become a bit excessive with these errors and if you know your HA instance is down it can become annoying. Lets only show the toast error when the user taps on the widget to update or its part of the normal update. This way we provide feedback when they ask for an update and we can't give them instead of when we proactively update the widgets.
I also had a friend hit a similar issue where he was on a flight and was connected to wifi without full data access so the errors still became excessive then.
Screenshots
n/a
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#n/a
Any other notes
Tested on my dev instance by creating widgets and shutting down the instance.