Map dpad down key to tab key in webviews #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The purpose of this change is to map the DPAD_DOWN key which is commonly found on remote controls to the TAB key. This will allow users to login to the HA app using the remote control. This is an unsupported experience and therefore we will not be publishing for Android TV. This is for sideloading only and we will not be doing any support here as we are only sending the TAB key. Both the android app and HA frontend are not optimized for the TV experience however, there are some users who just want to sideload the app and use it in its current form. At least with this change a user can do some VERY basic navigation (only one direction forward). Users should not expect bugs to be fixed until someone comes and adds support for DPAD keys in the front end (if that were to be accepted).
We will remove this workaround once someone spends the time to develop this feature there and its accepted. Until then the TAB key it will be.
This mapping only takes place in our authentication fragment and the webview. In all other screens the remote will function as normal. It will be a nuisance for anyone who wants to use this feature however it is there for those who absolutely need it.
Notifications will not work on Android TV as the app needs to support that feature and normal FCM messages are received but cannot be displayed. Widgets also are not supported. Some or most sensors should work.
So to reiterate this is an unsupported experience and users should not expect bugs to be fixed by the app as the frontend needs to support it. The frontend may also decide not to support it so users will need to keep that into consideration. This is why the app is not being published for those devices.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes