Small BLE Transmitter enhancement, handle Bluetooth state changes better, improve robustness #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansmitter from HA notifications.
…be incorrect on Bluetooth being disabled.
…luetoothSensorManager.kt Co-authored-by: Justin Bassett <bassett.justint@gmail.com>
- Power transmitter values between high and ultra low. Defaults to ultra low, should help with Battery concerns - A setting which allows the sensor to be turned on by default when the Enable all toggle is turned on. This is off by default, users have to actively seek out this sensor to turn it on.
# Conflicts: # app/src/main/java/io/homeassistant/companion/android/sensors/BluetoothSensorManager.kt
…stant#1366) Some points which may fix this issue * Make notification objects static * Use ServiceCompat for stopForeground * Additionally call cancel to remove notification
…ssistant#1343) * First cut add BLE beacon as new sensor. * Lint issues, also using hardcoded strings for state. * Fixes and small tidies following review. * Add command_ble_transmitter to MessagingService.kt, to control BLE Transmitter from HA notifications. * Make description more specific for settings. * Return if sensor not enabled * Spaced. * Command turn on for transmitter should stop it first, as state could be incorrect on Bluetooth being disabled. * Don't attempt to transmit if BT is off, and include that information in the state. * Update app/src/main/java/io/homeassistant/companion/android/sensors/BluetoothSensorManager.kt Co-authored-by: Justin Bassett <bassett.justint@gmail.com> * Add 2 new settings: - Power transmitter values between high and ultra low. Defaults to ultra low, should help with Battery concerns - A setting which allows the sensor to be turned on by default when the Enable all toggle is turned on. This is off by default, users have to actively seek out this sensor to turn it on. * Add battery warning to description. * Fix build - stray merge comma deletion. * Fix small description text error. Co-authored-by: Justin Bassett <bassett.justint@gmail.com>
…p sense of when device parameters have changed in one place.
JBassett
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An addition to the recent BLE Transmitter changes. It's been working well for me in general , but noticed some odd behaviours on changing BT state.
Screenshots
N/A
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
N/A
Any other notes