Prevent crash when removing default channel #1405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the following sentry error that I was able to reproduce:
Basically added a conditional check: https://android.googlesource.com/platform/frameworks/base.git/+/master/services/core/java/com/android/server/notification/NotificationManagerService.java#3412
Not sure if we should print a logger for this, it seemed best to just skip the error unless we decide to notify the user.
For the record our default channel seems to be
miscellaneous
Also fixes an incorrect variable in debug logs
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes