Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get the state of importance if we have running processes #1421

Merged
merged 1 commit into from Mar 11, 2021

Conversation

dshokouhi
Copy link
Member

Summary

Fixes the following sentry by skipping the iteration if we have no running processes:

java.lang.NullPointerException: Attempt to invoke interface method 'java.util.Iterator java.util.List.iterator()' on a null object reference
    at io.homeassistant.companion.android.sensors.AppSensorManager.updateImportanceCheck(AppSensorManager.kt:243)
    at io.homeassistant.companion.android.sensors.AppSensorManager.requestSensorUpdate(AppSensorManager.kt:100)
    at io.homeassistant.companion.android.sensors.SensorDetailFragment$onCreatePreferences$$inlined$let$lambda$1.onPreferenceChange(SensorDetailFragment.kt:103)
    at androidx.preference.Preference.callChangeListener(Preference.java:1118)
    at androidx.preference.TwoStatePreference.onClick(TwoStatePreference.java:67)
    at androidx.preference.Preference.performClick(Preference.java:1182)
    at androidx.preference.Preference.performClick(Preference.java:1166)
    at androidx.preference.SwitchPreference.performClick(SwitchPreference.java:195)
    at androidx.preference.Preference$1.onClick(Preference.java:181)
    at android.view.View.performClick(View.java:6307)
    at android.view.View$PerformClick.run(View.java:24948)
    at android.os.Handler.handleCallback(Handler.java:790)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:164)
    at android.app.ActivityThread.main(ActivityThread.java:6523)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:857)

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@JBassett JBassett merged commit 04ff1dd into home-assistant:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants