Shortcuts entity #1471
Merged
Shortcuts entity #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hopefully this branch is ok, I see a couple commits from the previous PR but the changes depicted are only from the branch as i have rebased the branch off master.
This now adds a shortcut type list preference so users can pick between Lovelace (default) and an Entity. For the Entity we grab a list of all entities and let the user select the one they want. We will add in the proper logic to switch between entity and lovelace type along with providing the proper data in shortcut.
This also fixes a bug that I found where the Pin Shortcut is enabled but non-functional as the entire
setOnPreferenceClickListenerwas incorrectly wrapped in a condition that would only succeed if the variables were met. Now we do one check inonResumeand let the rest of the preference listeners update the field as expected.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#485
Any other notes