Fix retrieval of media player image in widget #1483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the media player widget image never updated, turns out it never would because the URL we were using was never correct, now we load the actual URL and if on debug build we will print more logging errors to help out.
I also had to add a hard resize as my shield is in 4k and the image was too big, so sticking to 1920x1080 as it will load.
I had also opted not to change the
scaleType
because it either looks the way it does today or its very tiny, here is an example when we usecenterInside
and what it looks like today obviously not ideal but a larger image looks better lol, also need to consider music players:
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes