Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add focus,for rotary input #1780

Merged
merged 1 commit into from Oct 14, 2021
Merged

add focus,for rotary input #1780

merged 1 commit into from Oct 14, 2021

Conversation

apo-mak
Copy link
Contributor

@apo-mak apo-mak commented Oct 13, 2021

add focus,for rotary input.
#1779

Summary

quick fix for rotary input

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@dshokouhi
Copy link
Member

@apo-mak is this in addition to #1779 or should I close my PR in favor of yours? If they do the same thing then I will be happy to close my PR for this one :)

@apo-mak
Copy link
Contributor Author

apo-mak commented Oct 13, 2021

@dshokouhi omg sorry , i though it was an issue to be fixed.. it is getting late here...
Yes they do the same thing , i just did it on the XML file because i though this way it will survive a possible re implementation of the List UI.

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I closed my PR in favor of this one. Thanks for your contribution!!

@JBassett JBassett merged commit f51d7ef into home-assistant:master Oct 14, 2021
@apo-mak apo-mak deleted the patch-1 branch October 14, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants