Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to always try the internal URL first #1788

Merged
merged 3 commits into from Oct 20, 2021

Conversation

dshokouhi
Copy link
Member

Summary

Fixes: #1565 by adding a new option that enables once a Internal URL has been entered. Once selected we will always add the internal URL irregardless of the connected wifi SSID. This will be helpful for the users who prefer to keep location off.

The webview portion of the app already offers the ability to switch from internal to external.

Screenshots

image

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Copy link
Collaborator

@JBassett JBassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this only applies to the API calls we are making? As the setting currently reads I would expect the webview to also use this as a default.

@JBassett
Copy link
Collaborator

So now with that change did we basically eliminate the SSID checking? If so, we should probably remove/disable the SSID preference.

@dshokouhi
Copy link
Member Author

actually you are right, that last one should also contain isInternal() || isPrioritizeInernal() will update it after dinner, good catch :)

@JBassett JBassett merged commit a61a508 into home-assistant:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to prioritize the internal URL
3 participants