Updates for Android 12 #1807
Merged
Updates for Android 12 #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
requested changes
Oct 20, 2021
app/src/full/java/io/homeassistant/companion/android/sensors/LocationSensorManager.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/sensors/LocationSensorManager.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/notifications/MessagingService.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/notifications/MessagingService.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/notifications/MessagingService.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt
Show resolved
Hide resolved
app/src/full/java/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt
Show resolved
Hide resolved
JBassett
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the target to API 31.
Ran a few tests on enabling all sensors, sending a notification, getting location updates and making fixes along the way from the compiler and manual testing. Lots of changes but so far no issues after this final set. Also referencing behavior changes and think we got them all now?
One breaking change for users on Android 12 is that they need to grant Nearby Devices permission which is now required for getting bluetooth devices.
https://developer.android.com/about/versions/12/behavior-changes-12
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#pending location update
Any other notes