Add BLE beacon advertise mode setting #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to specific sensor settings
amadeo-alex
added a commit
to amadeo-alex/companion.home-assistant
that referenced
this pull request
Oct 30, 2021
Added information in regards to changes proposed by home-assistant/android#1856 (additional setting for advertise mode selection)
amadeo-alex
changed the title
JBassett
approved these changes
Oct 31, 2021
dshokouhi
pushed a commit
to home-assistant/companion.home-assistant
that referenced
this pull request
Nov 2, 2021
#603) * Reflected BLE iBeacon changes made by home-assistant/android/pull/1856 Added information in regards to changes proposed by home-assistant/android#1856 (additional setting for advertise mode selection) * added BETA tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds additional setting for the BLE iBecon sensor which allows for advertise mode selection (how often the iBecon is advertised).
Before this was hardcoded to be in low power mode (1Hz), after the change it is possible to select all three modes of operation: low power, balanced or low latency (low power mode is still the default)
The three first screenshots are from the HA app showing the setting itself. The fourth screenshot is from the nRF Connect app which I used to verify the broadcasts.
Results which I've observed are as follows (broadcasting device: samsung note 8, receiving device: samsung note 10 plus):
Screenshots
(if required I'll add screenshots in light mode right away)
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#603
Any other notes