fix warnings #1867
Merged
fix warnings #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TESTPERSONAL, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
JBassett
approved these changes
Nov 4, 2021
| mapOf() | ||
| ) | ||
| } | ||
| if (event != null && event.sensor.type == Sensor.TYPE_LIGHT) { |
There was a problem hiding this comment.
Think this is even better?
Suggested change
| if (event != null && event.sensor.type == Sensor.TYPE_LIGHT) { | |
| if (event?.sensor.type == Sensor.TYPE_LIGHT) { | |
| mapOf() | ||
| ) | ||
| } | ||
| if (event != null && event.sensor.type == Sensor.TYPE_PROXIMITY) { |
There was a problem hiding this comment.
Suggested change
| if (event != null && event.sensor.type == Sensor.TYPE_PROXIMITY) { | |
| if (event?.sensor.type == Sensor.TYPE_PROXIMITY) { | |
| if (lastUpdateSensor != null) { | ||
| if (lastUpdateSensor.enabled) | ||
| LastUpdateManager().sendLastUpdate(appContext, TAG) | ||
| if (lastUpdateSensor != null && lastUpdateSensor.enabled) { |
There was a problem hiding this comment.
Suggested change
| if (lastUpdateSensor != null && lastUpdateSensor.enabled) { | |
| if (lastUpdateSensor?.enabled == true) { |
| mapOf() | ||
| ) | ||
| } | ||
| if (event != null && event.sensor.type == Sensor.TYPE_STEP_COUNTER) { |
There was a problem hiding this comment.
Suggested change
| if (event != null && event.sensor.type == Sensor.TYPE_STEP_COUNTER) { | |
| if (event?.sensor.type == Sensor.TYPE_STEP_COUNTER) { | |
|
Hi @TESTPERSONAL, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
JBassett
approved these changes
Nov 8, 2021
|
@nick2525 we really need to figure out your commit email issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just fix some warnings
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes