New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings and favorites for wear so users can quickly execute actions they do regularly faster #1875
Add settings and favorites for wear so users can quickly execute actions they do regularly faster #1875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work once again! I'm impressed with your speed 😋
Haven't tested it out yet, but looks good!
wear/src/main/java/io/homeassistant/companion/android/home/HomeActivity.kt
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/HomeActivity.kt
Outdated
Show resolved
Hide resolved
I'm not sure what the best practices are for navigation in compose. But I was wondering if the HomeActivity is not becoming too large when it will contain all of the settings pages and subpages as well? |
Well we could move the composable to a separate file but navigating to composables instead of activities seems to be what the docs say. https://developer.android.com/jetpack/compose/navigation Also using the current method gives us the cool animation and handles the backstack etc.. |
Okay good then! I'll try to test it soon, am curious about the animations and functionality! |
ok did some refactoring so HomeActivity has a bit less going on, hopefully that helps make things easier to follow |
wear/src/main/java/io/homeassistant/companion/android/settings/SettingsComposable.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/util/CommonFunctions.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/util/CommonFunctions.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/settings/SettingsComposable.kt
Outdated
Show resolved
Hide resolved
2151dfa
to
fb909f8
Compare
Summary
Fixes: #1881
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#610
Any other notes
Theres a lot going on in this PR in a future PR lets do the phone side for grabbing and setting favorites :)