Remove automatic darkening of system bars #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In modern material design the system bars should not be darker then the rest of the app.
|
Hi @LasseRosenow, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Can you please post screenshots of what this looks like with the app? |
|
Of course :)
|
dshokouhi
approved these changes
Nov 7, 2021
JBassett
approved these changes
Nov 7, 2021
JBassett
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In modern material design the system bars should not be darker then the rest of the app.
Fixes #1501 which should not be closed.
Summary
Google material design changed over the years and they did not always update all the specifications accordingly.
But gladly with Material 3 / Material You, which's specification just got published, they updated everything.
The status bar color should now always be the same color as the AppBar and the navigation bar color should be the same as either the bottom bar or the background.
Spec: https://m3.material.io/styles/color/the-color-system/tokens
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes