Allow categories in Wear to be collapsed and expanded for easier navigation #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
requested changes
Nov 8, 2021
wear/src/main/java/io/homeassistant/companion/android/viewModels/EntityViewModel.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/HomeActivity.kt
Outdated
Show resolved
Hide resolved
dshokouhi
force-pushed
the
wear_collapse_categories
branch
from
8a6ad19
to
7eda0a1
Compare
JBassett
approved these changes
Nov 9, 2021
dshokouhi
force-pushed
the
wear_collapse_categories
branch
from
7eda0a1
to
7c709d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1880 For now I opted not to save this to local storage because its probably something that should be in Settings and completed alongside #1885 if a user really wants input booleans collapsed on each time we load its probably better for them to keep it at the bottom or maybe even hidden?
I also switched to a
ListHeaderfor the entities as it accounts for proper title spacing and arrangement.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes