Add settings for wear haptic feedback and toast on entity selection #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
force-pushed
the
wear_haptic_toast_settings
branch
3 times, most recently
from
fe7760d
to
62a6b23
Compare
JBassett
requested changes
Nov 11, 2021
wear/src/main/java/io/homeassistant/companion/android/home/MainViewModel.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/MainViewModel.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/views/EntityUi.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/views/EntityUi.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/views/SettingsView.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/views/SettingsView.kt
Outdated
Show resolved
Hide resolved
dshokouhi
force-pushed
the
wear_haptic_toast_settings
branch
from
62a6b23
to
03bf436
Compare
JBassett
requested changes
Nov 11, 2021
Comment on lines
32
to
36
| isHapticEnabled.value = homePresenter.getWearHapticFeedback() | ||
| isToastEnabled.value = homePresenter.getWearToastConfirmation() | ||
| entities.addAll(homePresenter.getEntities()) | ||
| isHapticEnabled.value = homePresenter.getWearHapticFeedback() | ||
| isToastEnabled.value = homePresenter.getWearToastConfirmation() |
There was a problem hiding this comment.
Don't need to call twice!
JBassett
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1878 by providing 2 new settings that default to
falseto preserve existing behavior. Once enabled the user will see a toast message and/or haptic feedback based on their choosing.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#pending
Any other notes