Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for websocket state changed events! #1906

Merged
merged 1 commit into from Nov 11, 2021

Conversation

JBassett
Copy link
Collaborator

@JBassett JBassett commented Nov 11, 2021

Summary

This PR adds support for listening to state changed events. We setup a flow that can be listened to and when the flow is no longer collection it will automatically unsubscribe from the events in the socket.

Screenshots

Screenshot_20211111-153412

Link to pull request in Documentation repository

N/A

Any other notes

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested debug APK and everything loads very fast. Same with state updates. This is awesome great work!!!!!!!!

@JBassett JBassett merged commit 70e441f into master Nov 11, 2021
@JBassett JBassett deleted the feature/stateChangedWebsocket branch November 11, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants