Editing wear favorites from the phone

[dshokouhi]

Summary

There is a lot going on here but I wanted to get the working code submitted early in case it can help anyone else looking to do something similar. Also a good time to think about the layout of phone settings overall.

• Get list of entities
• Get favorites from wearable
• Load entities and favorites along with selected favorites via checkbox
• Update favorites on wearable
• Recreate app bar in compose
• Re-organize code

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#613

Any other notes

Got a lot to do and we need to think about the design. Such as when a user has more than one wearable. How to access each of the settings etc...

[JBassett]

This needs to be rebased/merged so you can do you dependency injection with Hilt now.

[leroyboerefijn]

Great work! Awesome that we're starting to be able to change the wear app settings from the phone :)
Below a few feature requests. But please let me know if you think it's better to do this in a separate PR.

• Could you display friendly names in the settings? Or would you say that is for a follow up PR?
• Now when I make changes in the settings on the phone, it doesn't automatically update. It also doesn't update when I go home and re-open the app. Would it make sense to send a broadcast in PhoneSettingsListener, which is then picked up somewhere to update the list in the MainViewModel?

[dshokouhi]

Great work! Awesome that we're starting to be able to change the wear app settings from the phone :)

Thank you I appreciate that! This one was a bit of a challenge to get all the pieces working together but luckily a lot of the foundation was already there from your previous PR for sending the HA instance over :)

• Could you display friendly names in the settings? Or would you say that is for a follow up PR?

I could do that but then it might make sense to show a category saying these are Input Booleans or what not. I opted for entity ID so users know which entity it is. Honestly I figured we could redo the Rows to show the icons etc... in a more friendly way 😁

Whatever we do here though should probably be reusable so maybe making the Row a better compose element makes the most sense. We have a few places to add these to like QS tiles and Shortcuts for example. But neither of those were updated to compose yet.

• Now when I make changes in the settings on the phone, it doesn't automatically update. It also doesn't update when I go home and re-open the app.

So updating Wear when the app is open is something I couldn't get to work when I submitted this. However when the app was re-opened it always pulled in the latest favorites which were updated from the phone.

Would it make sense to send a broadcast in PhoneSettingsListener, which is then picked up somewhere to update the list in the MainViewModel?

I think a broadcast might be helpful here I'll have to look into that. 🤔, honestly didn't think about it since I felt the most important parts were already done 😂

[leroyboerefijn]

I could do that but then it might make sense to show a category saying these are Input Booleans or what not. I opted for entity ID so users know which entity it is. Honestly I figured we could redo the Rows to show the icons etc... in a more friendly way 😁

Whatever we do here though should probably be reusable so maybe making the Row a better compose element makes the most sense. We have a few places to add these to like QS tiles and Shortcuts for example. But neither of those were updated to compose yet.

That makes a lot of sense indeed. I suppose we can reuse that row composable as you say. Maybe we can add a main label with the friendly name (if it has one) and a secondary label with the entity ID? Then the next question is do you want the icon on the left and the checkbox on the right? Or the other way around? Or both on one side? :P

So updating Wear when the app is open is something I couldn't get to work when I submitted this. However when the app was re-opened it always pulled in the latest favorites which were updated from the phone.

Interesting! Somehow that doesn't work for me. I really need to fully close the app with the back gesture, instead of just the home button...

I think a broadcast might be helpful here I'll have to look into that. 🤔, honestly didn't think about it since I felt the most important parts were already done 😂

Oh that is definitely true! This is more a finishing touch on the user experience :)

[dshokouhi]

Interesting! Somehow that doesn't work for me. I really need to fully close the app with the back gesture, instead of just the home button...

ok that makes sense then because currently favorites only update in onCreate so I think a broadcast receiver to update the view model will be necessary then to trigger the update. I always went to the home screen by using the gesture during my testing :)

Maybe we can add a main label with the friendly name (if it has one) and a secondary label with the entity ID? Then the next question is do you want the icon on the left and the checkbox on the right? Or the other way around? Or both on one side? :P

Yea lots of considerations here, we could also try to make our own chip to help match the wear UI 😂

[leroyboerefijn]

Yea lots of considerations here, we could also try to make our own chip to help match the wear UI 😂

That would be a fun one haha 😁 But would indeed be nice to have a common design element

[dshokouhi]

Ok fixed the issue regarding favorites duplicating. I also added some code to update the favorite entities upon resuming the app. It was a bit difficult to try to get a receiver setup and its actually not correct. What we should do is save the entries to the DB and use a Flow of those values so its always updating just like we do today for entity updates.

[dshokouhi]

Hope I addressed them all appropriately :)