Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the websocket to reconnect #1940

Merged
merged 1 commit into from Nov 19, 2021
Merged

Conversation

JBassett
Copy link
Collaborator

Summary

Currently if we loose our connection with the websocket we also loose our state changed registration. This should force the websocket to reconnect.

Screenshots

N/A

Link to pull request in Documentation repository

N/A

Any other notes

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested briefly with wear and phone app

@dshokouhi
Copy link
Member

This PR also corrects an issue where the wear OS app is crashing when the watch has no data connection and the app is launched

@JBassett JBassett merged commit f468b8f into master Nov 19, 2021
@JBassett JBassett deleted the feature/websocketReconnect branch November 19, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants