Add extensions to Entity for domain, lights features #2322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Wear OS details panel introduced a new location in the code base where entity properties are used to determine feature support, in addition to phone/'full Android' device controls. To prevent duplicate code or code getting out of sync, especially when more features are supported on Wear OS in the future, and perhaps in more places (widgets?), I propose using extensions to keep the code in one place and make code elsewhere easier to read.
I've added the code to the existing file used for the
Entity
data class, but maybe another location is better (in theutil
package, or a newcommon.data.util
package)?Screenshots
n/a
Link to pull request in Documentation repository
Not needed
Any other notes