Breaking Change: Make coordinate attributes all lower case for HA compatibility #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would at least update all the attributes on this sensor. We can leave the rest of the sensors for another time, but it's strange to only fix a couple. |
JBassett
approved these changes
Mar 6, 2022
|
This has unexpected side effects - the device now shows twice on the map (1x |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all attributes to be all lower case to match the HA expectation in order to fix: #2339
https://github.com/home-assistant/core/blob/777ae584d49e45a074f74cdff47f0706597907c8/homeassistant/const.py#L434-L435
While I am ok with going through all sensors updating the attributes what do we do about the notification sensors that do not follow that format?
https://github.com/home-assistant/iOS/blob/master/Sources/Shared/API/Webhook/Sensors/GeocoderSensor.swift#L95-L110
Breaking change because users who relied on these attributes will need to update their configuration
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#706
Any other notes