Check for phone permissions when using call intent #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a feeling we may not be able to move forward with this PR because this might be one of those protected permissions we don't qualify for. Just realized it but will leave it open for discussion for now. https://developer.android.com/reference/android/content/Intent#ACTION_CALL
|
JBassett
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2343 by adding the proper permission to the manifest and then directing users who have not granted the permission to the app info screen to grant the permission, just like we do for bluetooth permissions.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#707
Any other notes