Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video notifications max memory #2353

Merged
merged 8 commits into from
Mar 10, 2022
Merged

Video notifications max memory #2353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
327bcbc
Compress bitmaps to avoid remoteview memory utilization error.
NickM-27 Mar 8, 2022
728bc2e
Cleanup
NickM-27 Mar 8, 2022
bdf6f11
Add log helpful for debugging
NickM-27 Mar 8, 2022
cff337d
Make formatting more consistent with standard notification view
NickM-27 Mar 8, 2022
5f4b16c
Switch to only using time based method
NickM-27 Mar 8, 2022
e848a57
Remove random image
NickM-27 Mar 8, 2022
b43bd98
Fix lint
NickM-27 Mar 8, 2022
5bb0090
Update order of imports
NickM-27 Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 23 additions & 29 deletions app/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,16 @@ import io.homeassistant.companion.android.settings.SettingsActivity
import io.homeassistant.companion.android.util.UrlHandler
import io.homeassistant.companion.android.webview.WebViewActivity
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Deferred
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
import kotlinx.coroutines.async
import kotlinx.coroutines.awaitAll
import kotlinx.coroutines.launch
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.withContext
import org.json.JSONObject
import java.io.ByteArrayOutputStream
import java.net.URL
import java.net.URLDecoder
import java.util.Locale
Expand Down Expand Up @@ -206,11 +210,9 @@ class MessagingManager @Inject constructor(
listOf(BLE_ADVERTISE_BALANCED, BLE_ADVERTISE_LOW_LATENCY, BLE_ADVERTISE_LOW_POWER)

// Video Values
const val VIDEO_MAX_FRAMES = 5
const val VIDEO_FRAME_CHUNKS = 20
const val VIDEO_START_MICROSECONDS = 100000L
const val VIDEO_INCREMENT_MICROSECONDS = 500000L
const val VIDEO_GUESS_MICROSECONDS = 7000000L
const val VIDEO_INCREMENT_MICROSECONDS = 2000000L
const val VIDEO_GUESS_MILLISECONDS = 7000L
}

private val mainScope: CoroutineScope = CoroutineScope(Dispatchers.Main + Job())
Expand Down Expand Up @@ -1196,6 +1198,7 @@ class MessagingManager @Inject constructor(
data[VIDEO_URL]?.let {
val url = UrlHandler.handle(urlUseCase.getUrl(), it)
getVideoFrames(url, !UrlHandler.isAbsoluteUrl(it))?.let { frames ->
Log.d(TAG, "Found ${frames.size} frames for video notification")
RemoteViews(context.packageName, R.layout.view_image_flipper).let { remoteViewFlipper ->
if (frames.isNotEmpty()) {
frames.forEach { frame ->
Expand Down Expand Up @@ -1231,7 +1234,7 @@ class MessagingManager @Inject constructor(
Dispatchers.IO
) {
url ?: return@withContext null
val frames = mutableListOf<Bitmap>()
val processingFrames = mutableListOf<Deferred<Bitmap?>>()

try {
MediaMetadataRetriever().let { mediaRetriever ->
Expand All @@ -1242,32 +1245,17 @@ class MessagingManager @Inject constructor(
mediaRetriever.setDataSource(url.toString(), hashMapOf())
}

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
var frameIndex = 0
val frameCount = mediaRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_FRAME_COUNT)?.toIntOrNull() ?: VIDEO_FRAME_CHUNKS
val frameIncrement = frameCount / VIDEO_FRAME_CHUNKS
var lastWasNull = false

while (frames.size < VIDEO_MAX_FRAMES && !lastWasNull) {
try {
mediaRetriever.getFrameAtIndex(frameIndex)
?.let { smallFrame ->
frames.add(smallFrame)
} ?: run { lastWasNull = true }
} catch (e: Exception) {
if (frameIndex + frameIncrement > frameCount) {
lastWasNull = true
}
}
frameIndex += frameIncrement
}
} else {
val durationInMicroSeconds = ((mediaRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_DURATION)?.toLongOrNull() ?: VIDEO_GUESS_MICROSECONDS))
val durationInMicroSeconds = ((mediaRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_DURATION)?.toLongOrNull() ?: VIDEO_GUESS_MILLISECONDS)) * 1000

// Start at 100 milliseconds and get frames every 500 milliseconds until reaching the end
// Start at 100 milliseconds and get frames every 2 seconds until reaching the end
run frameLoop@{
for (timeInMicroSeconds in VIDEO_START_MICROSECONDS until durationInMicroSeconds step VIDEO_INCREMENT_MICROSECONDS) {
if (processingFrames.size >= 5) {
return@frameLoop
}

mediaRetriever.getFrameAtTime(timeInMicroSeconds, MediaMetadataRetriever.OPTION_CLOSEST)
?.let { smallFrame -> frames.add(smallFrame) }
?.let { smallFrame -> processingFrames.add(async { smallFrame.getCompressedFrame() }) }
}
}

Expand All @@ -1278,7 +1266,13 @@ class MessagingManager @Inject constructor(
Log.e(TAG, "Couldn't download video for notification", e)
}

return@withContext frames
return@withContext processingFrames.awaitAll().filterNotNull()
}

private fun Bitmap.getCompressedFrame(): Bitmap? =
ByteArrayOutputStream().let { outputStream ->
this.compress(Bitmap.CompressFormat.JPEG, 50, outputStream)
outputStream.toByteArray().let { bytes -> BitmapFactory.decodeByteArray(bytes, 0, bytes.size) }
}

private fun handleActions(
Expand Down
10 changes: 8 additions & 2 deletions app/src/main/res/layout/view_image_flipper.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical">
Expand All @@ -9,14 +10,19 @@
style="@style/TextAppearance.Compat.Notification.Title"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="center_vertical" />
android:gravity="center_vertical"
android:maxLines="2"
tools:text="@tools:sample/lorem" />

<TextView
android:id="@+id/info"
style="@style/TextAppearance.Compat.Notification.Info"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="center_vertical" />
android:gravity="center_vertical"
android:maxLines="2"
android:textSize="14sp"
tools:text="@tools:sample/lorem/random" />

<ViewFlipper
android:id="@+id/frame_flipper"
Expand Down