Create a WidgetConfigureActivity base class #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NotWoods In case you hadn't noticed, ktlint doesn't like the code and there's also a merge conflict now Aside from that this seems like a good improvement to me! |
NotWoods
force-pushed
the
shared-widget-configure-activity
branch
from
61b9c7c
to
e944959
Compare
NotWoods
force-pushed
the
shared-widget-configure-activity
branch
from
e944959
to
a72d772
Compare
JBassett
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a base class for the widget configure activities. As a result some logic can be shared - initially just the delete dialog.
Also updated the delete widget operation to use coroutines.