Add a sensor for high accuracy update interval #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it make more sense for this to be an attribute for the existing 'high accuracy mode' sensor? That sensor tells you if it's enabled or not, the update interval is a detail for that state. |
When high accuracy mode is enabled and the update interval changes we only call a restart and in this case the state will not change and the attribute value will not update. So I had opted to keep it separate to ensure the sensor is as up to date as possible. |
JBassett
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2485 the state will update as soon as the value changes which takes place when the service is started or restarted
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#737
Any other notes