Improve time zone sensor state #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update string to reflect if the time zone is using summer/daylight savings time or not - Use the user's language settings instead of always using English
dshokouhi
reviewed
May 21, 2022
app/src/main/java/io/homeassistant/companion/android/sensors/TimeZoneManager.kt
Outdated
Show resolved
Hide resolved
jpelgrom
changed the title
dshokouhi
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the time zone sensor's state to the 'current' name that reflects whether the time zone is in summer/daylight savings time or not (bonus: it 'fixes' 50% of #2530).
Screenshots
The sensor previously had 'Central European Standard Time' as the state.
Link to pull request in Documentation repository
n/a
Any other notes