Improve HA version check when unable to read config #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the app is unable to read the Home Assistant config (for example, if the server is temporarily down, the device has no internet connection, ...), this should return the stored HA version + still retry the next time instead of overwriting it with null/empty string as successful. This was probably the intended behavior, but changed when switching to the websocket which returns
nullon problems instead of throwing an exception.This will prevent version 'downgrades' which resulted in less functionality for sensor updates and/or the app showing a security warning.
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes