Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Android WebView quick bar gesture support #2690

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Jul 18, 2022

Summary

A three finger swipe gesture was added as a workaround to open the quick bar while it was only possible with a physical keyboard; Home Assistant 2022.5 added a button for it to the toolbar and a later update broke support for the app's workaround (see this comment). Because it is no longer functional on recent versions and an alternative is available, add a comment in the code to mark it for removal.

Closes #2686

Screenshots

n/a

Link to pull request in Documentation repository

The documentation is related but doesn't depend on this PR being merged to be true

Documentation: home-assistant/companion.home-assistant#777

Any other notes

@dshokouhi
Copy link
Member

So I wonder how long we should consider to keep things backwards compatible, I believe this feature is 2 months old now but I am not sure what is considered a sane amount of time to wait.

@jpelgrom
Copy link
Member Author

Home Assistant moves fast and the feature is already broken in recent versions, but I understand the hesitation.

Perhaps a better first step would be to mark the feature as deprecated in the docs (also add note that it is no longer working on recent versions) and give users more time to migrate, for example 6 months since introduction -> remove in 2022.11? There doesn't appear to be an official policy for deprecation but looking at analytics.home-assistant.io 6 months seems reasonable to me.

It's also possible to leave the feature as it is, and only update the docs. It's not actively breaking something and the code was recently updated to make it work correctly.

@dshokouhi
Copy link
Member

I think adding in a note in the docs and maybe even a code comment to remove it once time has passed would be good.

If we really want to keep this feature then we will need to enhance the HA frontend so the external bus can be leveraged to trigger the quick bar. We still need that to be done to avoid our more info pop-up hack :) I created a feature request for that a while ago lol.

@jpelgrom jpelgrom changed the title Remove WebViewActivity quick bar gesture Deprecate Android WebView quick bar gesture support Jul 21, 2022
@jpelgrom
Copy link
Member Author

Alright, let's make it less destructive :) I've checked which frontend version includes the problematic change and added a comment in the code + docs.

(Tried 'fixing' it with more workarounds as well but wasn't able to get it to work.)

@JBassett JBassett merged commit f4eea70 into home-assistant:master Jul 22, 2022
@jpelgrom jpelgrom deleted the remove-webview-gesture branch July 22, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3-fingers gesture (WebViewActivity?) doesnt work anymore
4 participants