Remove error message on null template #2735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #2653 it was discovered that templates can be valid and return
null
, and some simple changes were made to handle it.This PR builds on it and addresses a comment by another user:
null
will now be shown as "null" like in the frontend, and "Error in template" will only be shown if there is actually an error. If users want to avoid seeing "null" it can be handled in the template.Screenshots
n/a, template widget/tile hasn't visually changed
Link to pull request in Documentation repository
n/a
Any other notes
On error the server will give the app a response like this:
Which throws:
A stacktrace