Calculate fan speed step count #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
Aug 26, 2022
common/src/main/java/io/homeassistant/companion/android/common/data/integration/Entity.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Joris Pelgröm <jpelgrom@users.noreply.github.com>
jpelgrom
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the number of steps shown on the detail page of a fan entity because the default number of nine steps wouldn't work for fan entities with some percentage step size. This new function will calculate an optimal number of steps based on the percentage step size of the fan with a maximum of nine steps.
Screenshots
Before:
After:
Before:
After:
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
This fixes #2815