Prevent crashes on Wear when offline / server no longer available #2825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While helping a user with problems in their Wear app, it became clear that the app provides almost no options to do anything and is easy to crash if the server can't be reached. This PR aims to address that.
revokeSession
, instead of crashing catch it and continue with logout in the app as the server might no longer be available. This better matches the options available when the main app can't reach the server.Without the last two changes, if the server is no longer available the user might be 'locked in' with no way to change the server aside from resetting the entire app.
Screenshots
The main screen now shows the settings button below the 'Error loading entities' message:
Link to pull request in Documentation repository
n/a
Any other notes