Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in websocket unsubscribe/resubscribe #2855

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Fix race condition in websocket unsubscribe/resubscribe #2855

merged 1 commit into from
Sep 5, 2022

Commits on Sep 5, 2022

  1. Fix race condition in websocket unsubscribe/resubscribe 

     - If the app tries to start a new websocket subscription before the last one was properly unsubscribed, the app will return a flow that is null and crash. To prevent this, change the unsubscribe logic to immediately remove the subscription ID - the confirmation isn't used. This will allow the app to start a new subscription and create a new flow even if the previous unsubscribe hasn't yet fully finished (which is OK).
    @jpelgrom
    jpelgrom committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6bb07cd View commit details
    Browse the repository at this point in the history