Fix template widgets that render null in websocket subscription #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Just like in the preview, null is a valid result and should be handled by the app
jpelgrom
changed the title
dshokouhi
approved these changes
Sep 8, 2022
JBassett
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2865 by handling templates that return
null, which is a valid result. These will, like in the preview and developer tools, show up as the string "null" on the widget.(A similar change was previously made for the preview, but somehow this wasn't considered for subscriptions 馃檭)
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes