Tweak camera control active state: true if not unavailable #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the thumbnail template for the camera control to active as long as the camera isn't unavailable and the app was able to download an image, to show the camera image more often and better match the frontend.
dshokouhi
approved these changes
Sep 10, 2022
JBassett
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2870 by seting the thumbnail template for the camera control to active as long as the camera isn't
unavailableand the app was able to download an image. This change aims to show the camera image more often and better match the frontend.Screenshots
It depends on the device how controls are shown, this is on the Android 13 emulator.
Note the idle 'camera' that is now visible (showing a weather map). In the current version of the app both of these tiles would look like the unavailable camera in the screenshot.
Link to pull request in Documentation repository
n/a
Any other notes