New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Change: Retrieve beacon name for beacon monitor sensor #2941
Conversation
I'm afraid this would again complicate/break the work in e.g. NodeRED, do you think it's good to use attributes in an attribute? |
Sorry but this is not about what you need, or what works or not out of the box with NodeRed. If you don't need this additional data, can't you use a simple regex or something similar to filter them out in NodeRed? We don't know yet what will be the final format to hold this information but as far as we respect general guidance and practices, I am fine with that. I fully support the request to avoid spaces in the name of the attributes. Beyond that, I suggested another format in the original issue that seems more "YAMLish", but maybe not better than this original draft proposal. In your case, I think it would be even better if you could specify the "sub attribute" for your beacon, something like: |
This could very well be 👍 |
update: Looks like we cannot change the AltBeacon/android-beacon-library#987 (comment)
Will need to update this PR to reflect that. |
closing this PR as the approach is not right for this |
Summary
Fixes: #2932 by retrieving the
name
in the Beacon Monitor.This will be a breaking change as we are changing the attribute format
Leaving as a draft to get feedback and also need some help in making the array look better in the attributes. Not really sure what type of conversion we need to do there. As of now its a string 🤷♂️
Example of new attributes in current state of this PR:
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#pending
Any other notes