Only use internal URL when data is also using Wi-Fi

[jpelgrom]

Summary

Add a check to the external/internal URL logic to make sure that the device is not only connected to a Home Wi-Fi network, but is also using that network for data for using the internal URL. This better matches the expected behavior. Inspired by #3006.

A device can be connected to Wi-Fi but may be using a different (usually mobile) network for data for example if the internet is down or the network is considered "low quality". Expected log output in these situations is something like:

2022-10-29 15:32:21.317 11938-12081 UrlRepository           io....stant.companion.android.debug  D  localUrl is: true, usesInternalSsid is: true, usesWifi is: false
2022-10-29 15:32:21.318 11938-12081 UrlRepository           io....stant.companion.android.debug  D  Using external URL

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

Testing note: my Pixel on Android 13 simply hides the Wi-Fi icon from the status bar / shows the 4G data icon when Wi-Fi is not used for data, even though it may be connected. Check the system settings app to be sure.

[dshokouhi]

Nice improvement!

[marazmarci]

Thanks for this improvement! It will surely be useful.

I was wondering about a less frequent use case, when the phone is connected to Ethernet and the device has cellular connection as a fallback. Here in this PR, the changes only take WiFi into account, so in the Ethernet use case, the same problem will arise.

[jpelgrom]

I was wondering about a less frequent use case, when the phone is connected to Ethernet and the device has cellular connection as a fallback. Here in this PR, the changes only take WiFi into account, so in the Ethernet use case, the same problem will arise.

Currently ethernet won't be recognized as a home network, so I think this would be part of feature request #2532?

[marazmarci]

Currently ethernet won't be recognized as a home network, so I think this would be part of feature request #2532?

Oh wow, yes, I saw this FR earlier, but forgot about it.

Yes, I also think this should be part of it.