Don't crash when system is unable to handle download intent #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When trying to forward a download intent to the system catch the exception that is thrown if the system can't handle it to prevent a crash
dshokouhi
approved these changes
Nov 27, 2022
JBassett
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to forward a download intent to the system catch the exception that is thrown if the system can't handle it to prevent a crash.
This should close #3098 as explained in my comment on the issue.
Screenshots
The app will show a toast to indicate the download is not supported when an exception is caught, for example when trying to use a blob URL:
blob.mp4
Link to pull request in Documentation repository
n/a
Any other notes