Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable receiving broadcast to update location #355

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Enable receiving broadcast to update location #355

merged 3 commits into from
Feb 10, 2020

Conversation

quthla
Copy link
Contributor

@quthla quthla commented Feb 9, 2020

This enables other apps to send a broadcast to the HA app to update the device tracker's location

@JBassett
Copy link
Collaborator

I think you want to get rid of this line as well:
https://github.com/home-assistant/home-assistant-android/pull/355/files#diff-c8cc2dd42271f2bf39c6aa81eb6a5529R59

Otherwise anyone calling this will need to have the android.permission.RECEIVE_BOOT_COMPLETED permission.

The name of a permission that broadcasters must have to send a message to the broadcast receiver. If this attribute is not set, the permission set by the <application> element's permission attribute applies to the broadcast receiver. If neither attribute is set, the receiver is not protected by a permission.

@quthla
Copy link
Contributor Author

quthla commented Feb 10, 2020

Actually, my app holds that permission anyway, so I'll be fine but maybe others won't.

I wasn't sure why you put it there, so I asked first before I would remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants