Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide devices that are home from the android auto navigation screen #3610

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

dshokouhi
Copy link
Member

@dshokouhi dshokouhi commented Jun 27, 2023

Summary

Just a small clean up PR. I think if you have a lot of devices that are at home and have a device tracker it may seem a bit redundant to list them all. One example is if a user has wall mounted tablets with the app installed.

I decided not to touch person entity as you may not care if they are home or not, you just want to navigate to them.

sensors and zones are left untouched as sensors may not have an expected state and zones should always be shown like person.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#949

Any other notes

@jpelgrom
Copy link
Member

This change also needs a docs update

@dshokouhi
Copy link
Member Author

This change also needs a docs update

good call, updated the docs :)

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change in my opinion as most device trackers will be linked to a person

@JBassett JBassett merged commit 72722bd into home-assistant:master Jun 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants