Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create release number/notes for PRs #3749

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Aug 1, 2023

Summary

Don't create a release number and release notes for PRs

  • release number is unused
  • release notes requires a token with write access which should not be given to forks and without it the action will fail, so remove step

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

@jpelgrom
Copy link
Member Author

jpelgrom commented Aug 1, 2023

Yes this is ironic after a PR to update the release notes was just merged and wouldn't have been possible without the release notes step, but I realized this will break the CI for external PRs (which is probably close to 99%) only when it was merged.

@JBassett JBassett enabled auto-merge (squash) August 1, 2023 20:15
@JBassett JBassett merged commit 8be42b0 into home-assistant:master Aug 1, 2023
4 checks passed
@jpelgrom jpelgrom deleted the fix-pr-release-notes branch August 1, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants