Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of adding domains to remove loader when user has no actionable entities #3757

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

dshokouhi
Copy link
Member

Summary

Fixes #3756 by keeping track of when we first load domains so we only show the loader for a brief period of time instead of endlessly when a user has no entities that are considered actionable by the app.

at a minimum users will have 1 person entity so we should expect once domains are loaded that we have all entities

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@jpelgrom
Copy link
Member

jpelgrom commented Aug 4, 2023

You should also invalidate if domainsAdded was false

@dshokouhi
Copy link
Member Author

You should also invalidate if domainsAdded was false

done I didnt add it initially as the value only changes once :)

@JBassett JBassett merged commit 77141c2 into home-assistant:master Aug 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Auto stuck whilst loading
3 participants