Replace deprecated menu functions with MenuProvider #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add HelpMenuProvider to Android Auto favorites - Fix notification history fragment having no view because of missing super call - Fix crash in device controls view if a server that is offline is selected
- Undo formatting change in SettingsActivity - Don't require each activity to convert the string to URIs if we can do it in one place
dshokouhi
approved these changes
Aug 11, 2023
JBassett
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes @NotWoods'
MenuProviderPR #2974 (once again, thanks for the initial work!) and squashes, rebases and updates it for the latest code and app features and fixes several issues in the original PR. Also takes out switching the log fragment to viewbinding to limit changes.Closes #2974
Screenshots
No visual changes if everything was done correctly :)
Link to pull request in Documentation repository
n/a
Any other notes