Discard notifications when not registered to prevent crash #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix crash 1 from #3708 (link to line for version in issue).
IllegalArgumentExceptionsuggests the server for the ID doesn't exist, which can only happen if a notification is received while not registered (as it already falls back to the default server if there is no server found for the webhook ID). As a lot of features depend on having a server for notifications discard them.I guess people are sending notifications after logging out? (Note that the notification data is still saved to the database so not completely lost and available for troubleshooting if required.)
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes