Add Android 14 device controls panel #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable panel by default - Add area to controls settings on Android 14 to enable/disable panel
- Add setting to choose which server and path to use for the panel
JBassett
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #3566
Screenshots
* The warning about removing previous controls only shows up when changing the setting from built-in to dashboard
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#978
Any other notes
Testing note: transitioning activities like done here works but clearly it wasn't the intended use case and there may be some flickering when the device is locked. Finishing in
onPause()instead of immediately after launching seems to reduce it but on quick, repeated launches I could still get some odd behavior (tested on Android 14 beta 5.3).