Update Chip and ToggleChip to Button and ToggleButton except for WearToggleChip
#3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
commented
Oct 5, 2023
jpelgrom
reviewed
Oct 5, 2023
wear/src/main/java/io/homeassistant/companion/android/util/ContentDescription.kt
Outdated
Show resolved
Hide resolved
...in/java/io/homeassistant/companion/android/complications/views/ComplicationConfigMainView.kt
Outdated
Show resolved
Hide resolved
...in/java/io/homeassistant/companion/android/complications/views/ComplicationConfigMainView.kt
Outdated
Show resolved
Hide resolved
dshokouhi
changed the title
Chip and ToggleChip to Button and ToggleButton except for WearToggleChip
jpelgrom
reviewed
Oct 5, 2023
wear/src/main/java/io/homeassistant/companion/android/util/ToggleSwitch.kt
Outdated
Show resolved
Hide resolved
jpelgrom
reviewed
Oct 5, 2023
wear/src/main/java/io/homeassistant/companion/android/util/ToggleButtonControls.kt
Outdated
Show resolved
Hide resolved
wear/src/main/java/io/homeassistant/companion/android/home/views/MainView.kt
Outdated
Show resolved
Hide resolved
|
This is starting to grow on me ❤️ Before merging the difference in disabled states should be resolved in my opinion. |
jpelgrom
reviewed
Oct 6, 2023
wear/src/main/java/io/homeassistant/companion/android/home/views/SetShortcutsTileView.kt
Outdated
Show resolved
Hide resolved
jpelgrom
approved these changes
Oct 6, 2023
JBassett
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
ChiptoButtonandToggleChiptoToggleButtonrespectivelyAlso bumps material3 library to latest version
Adds a preview for a missing button
Screenshots
ignore background colors as the screenshot is from the compose preview whcih doesnt get it quite right
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes